[kteam-tools PATCH] maint-getabis: ABI sorting with C locale

Andy Whitcroft apw at canonical.com
Sat Feb 11 16:15:31 UTC 2017


On Thu, Feb 09, 2017 at 12:24:47PM -0200, Thadeu Lima de Souza Cascardo wrote:
> Whenever different people update a kernel ABI, it's possible a different locale
> is used, and ABI is changed, though nothing has really changed. This causes
> some spurios ABI changes that make it more difficult to review differentes
> between releases.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>
> ---
>  maintscripts/maint-getabis | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/maintscripts/maint-getabis b/maintscripts/maint-getabis
> index f375cc1..2defb70 100755
> --- a/maintscripts/maint-getabis
> +++ b/maintscripts/maint-getabis
> @@ -213,7 +213,8 @@ def DownloadPackage(pkgname, srcpkgname):
>  # remove the package on success.
>  #------------------------------------------------------------------------------
>  def ExtractPackage(pkg, tmpdir, abiversion, flavour):
> -	cmd  = "tmpdir=" + tmpdir + "\n"
> +	cmd  = "export LC_ALL=C.UTF-8\n"
> +	cmd += "tmpdir=" + tmpdir + "\n"
>  	cmd += "pkg=" + pkg + "\n"
>  	cmd += "abiver=" + abiversion + "\n"
>  	cmd += "flavour=" + flavour + "\n"

If we need this here, do we not want this in "getabis" in the trees as
well and for the same reason.

-apw




More information about the kernel-team mailing list