[kteam-tools][PATCH] git-build-kernel: embed sha in the /tmp/kernel-user-xxxxxxx build dir name

Kamal Mostafa kamal at canonical.com
Thu Feb 2 17:03:20 UTC 2017


On Wed, Feb 01, 2017 at 11:06:40AM +0100, Stefan Bader wrote:
> > +GITSHASHORT="`git log -1 --pretty=%h ${GITBRANCH%%refs/heads/} --`"
> > +[ -z "$GITSHASHORT" ] && {
> > +    echo "warning: Can't determine GITSHASHORT from GITBRANCH=$GITBRANCH" 1>&2
> > +}
> 
> Maybe it would be better to just fallback to the old naming when GITSHASHORT
> happens to be ""...

I'm pretty sure that GITSHASHORT can't ever actually end up blank there.
The test and warning are just in case I'm wrong about that (and the
script works even if that somehow does occur).

Anyway, [PATCH v2] makes it even clearer that this can-never-happen
situation happened, if it does.  :-)
 
 -Kamal





More information about the kernel-team mailing list