ACK: [xenial v2 0/7] Add Broadcom bnxt_en backport driver
Kleber Souza
kleber.souza at canonical.com
Thu Aug 24 16:49:28 UTC 2017
On 08/17/17 13:32, Juerg Haefliger wrote:
> BugLink: http://bugs.launchpad.net/bugs/1711056
> Binary test packages & patchset: http://people.canonical.com/~juergh/review/lp1711056/ (the new bnxt_en_bpo driver is in linux-image-extras)
> Test repo: https://git.launchpad.net/~juergh/ubuntu/+source/linux/+git/xenial/log/?h=review/lp1711056
>
> Changes from v1:
> Patch 6: Also modify the module name used to register the driver
> with the PCI core.
>
> This patch series adds the 1.8.1 version of the bnxt_en driver as an
> Ubuntu third-party driver under ubuntu/bnxt. Per Oracle's request.
>
> Patch 1: Simply imports everying from the provided tarball.
> Patch 2: Simplifies the Makefile and drops detection logic that tries
> to find the source code.
> Patch 3: Removes hard-coded CFLAGS that are set by the kernel's Makefile.
> Patch 4: Moves the hard-coded CONFIG options to a dedicated Kconfig file
> so that the driver be enabled/disabled via the kernel's config
> file.
> Patch 5: Removes the PCI_IDs that are handled by the regular 4.4 driver,
> so that the new backport driver is only loaded for NICs that the
> old driver doesn't support.
> Patch 6: Renames the driver from bnxt_en to bnxt_en_bpo.
> Patch 7: Updates the kernel config file to enable the new driver.
>
> Juerg Haefliger (7):
> UBUNTU: SAUCE: bnxt_en_bpo: Import bnxt_en driver version 1.8.1
> UBUNTU: SAUCE: bnxt_en_bpo: Drop distro out-of-tree detection logic
> UBUNTU: SAUCE: bnxt_en_bpo: Remove unnecessary compile flags
> UBUNTU: SAUCE: bnxt_en_bpo: Move config settings to Kconfig
> UBUNTU: SAUCE: bnxt_en_bpo: Remove PCI_IDs handled by the regular
> driver
> UBUNTU: SAUCE: bnxt_en_bpo: Rename the backport driver to bnxt_en_bpo
> UBUNTU: bnxt_en_bpo: [Config] Enable CONFIG_BNXT_BPO=m
>
> debian.master/config/config.common.ubuntu | 3 +
> ubuntu/Kconfig | 7 +
> ubuntu/Makefile | 5 +
> ubuntu/bnxt/COPYING | 339 ++
> ubuntu/bnxt/ChangeLog | 3952 +++++++++++++
> ubuntu/bnxt/Kconfig | 29 +
> ubuntu/bnxt/Makefile | 411 ++
> ubuntu/bnxt/README.TXT | 948 +++
> ubuntu/bnxt/RELEASE.TXT | 1594 +++++
> ubuntu/bnxt/bnxt.c | 9061 +++++++++++++++++++++++++++++
> ubuntu/bnxt/bnxt.h | 1421 +++++
> ubuntu/bnxt/bnxt_compat.h | 776 +++
> ubuntu/bnxt/bnxt_dcb.c | 610 ++
> ubuntu/bnxt/bnxt_dcb.h | 42 +
> ubuntu/bnxt/bnxt_ethtool.c | 2946 ++++++++++
> ubuntu/bnxt/bnxt_ethtool.h | 45 +
> ubuntu/bnxt/bnxt_fw_hdr.h | 120 +
> ubuntu/bnxt/bnxt_hsi.h | 8155 ++++++++++++++++++++++++++
> ubuntu/bnxt/bnxt_nvm_defs.h | 75 +
> ubuntu/bnxt/bnxt_ptp.c | 461 ++
> ubuntu/bnxt/bnxt_ptp.h | 70 +
> ubuntu/bnxt/bnxt_sriov.c | 1025 ++++
> ubuntu/bnxt/bnxt_sriov.h | 44 +
> ubuntu/bnxt/bnxt_ulp.c | 348 ++
> ubuntu/bnxt/bnxt_ulp.h | 94 +
> ubuntu/bnxt/bnxt_xdp.c | 252 +
> ubuntu/bnxt/bnxt_xdp.h | 27 +
> 27 files changed, 32860 insertions(+)
> create mode 100644 ubuntu/bnxt/COPYING
> create mode 100644 ubuntu/bnxt/ChangeLog
> create mode 100644 ubuntu/bnxt/Kconfig
> create mode 100644 ubuntu/bnxt/Makefile
> create mode 100644 ubuntu/bnxt/README.TXT
> create mode 100644 ubuntu/bnxt/RELEASE.TXT
> create mode 100644 ubuntu/bnxt/bnxt.c
> create mode 100644 ubuntu/bnxt/bnxt.h
> create mode 100644 ubuntu/bnxt/bnxt_compat.h
> create mode 100644 ubuntu/bnxt/bnxt_dcb.c
> create mode 100644 ubuntu/bnxt/bnxt_dcb.h
> create mode 100644 ubuntu/bnxt/bnxt_ethtool.c
> create mode 100644 ubuntu/bnxt/bnxt_ethtool.h
> create mode 100644 ubuntu/bnxt/bnxt_fw_hdr.h
> create mode 100644 ubuntu/bnxt/bnxt_hsi.h
> create mode 100644 ubuntu/bnxt/bnxt_nvm_defs.h
> create mode 100644 ubuntu/bnxt/bnxt_ptp.c
> create mode 100644 ubuntu/bnxt/bnxt_ptp.h
> create mode 100644 ubuntu/bnxt/bnxt_sriov.c
> create mode 100644 ubuntu/bnxt/bnxt_sriov.h
> create mode 100644 ubuntu/bnxt/bnxt_ulp.c
> create mode 100644 ubuntu/bnxt/bnxt_ulp.h
> create mode 100644 ubuntu/bnxt/bnxt_xdp.c
> create mode 100644 ubuntu/bnxt/bnxt_xdp.h
>
The backport looks good to me.
Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
More information about the kernel-team
mailing list