NACK: [Xenial][PATCH 1/2] net/wireless: do not dereference invalid pointer

[Jesse Sung]

Hi Stefan,

Sorry I didn't get this mail before I sent v2 patches...

2017-08-24 16:00 GMT+08:00 Stefan Bader <stefan.bader at canonical.com>:
>
> On 24.08.2017 09:30, Wen-chien Jesse Sung wrote:
> > BugLink: https://launchpad.net/bugs/1712746
> >
> No SRU justification in bug report.
>
> > The wiphy may be NULL sometimes. Do not dereference when it's NULL.
> >
> No source quoted. Cherry-picked? From where? Possibly needed in Zesty, too?

There is a NULL pointer deference oops with 4.13-rc6, but it happens
at a different
location. Thus I think these patches may or may not fit into Zesty. Will need
to reproduce this issue with a Zesty kernel and then we'll know if
these patches help.

Thanks,
Jesse

>
>
> -Stefan
> > Signed-off-by: Wen-chien Jesse Sung <jesse.sung at canonical.com>
> > ---
> >  net/wireless/util.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/wireless/util.c b/net/wireless/util.c
> > index baf7218..e358511 100644
> > --- a/net/wireless/util.c
> > +++ b/net/wireless/util.c
> > @@ -121,7 +121,7 @@ struct ieee80211_channel *__ieee80211_get_channel(struct wiphy *wiphy,
> >       int i;
> >
> >       for (band = 0; band < IEEE80211_NUM_BANDS; band++) {
> > -             sband = wiphy->bands[band];
> > +             sband = wiphy ? wiphy->bands[band] : NULL;
> >
> >               if (!sband)
> >                       continue;
> >
>
>
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>