ACK: [PATCH TVXZA] UBUNTU: [Packaging] sort ABI files with C.UTF-8 locale

Colin Ian King colin.king at canonical.com
Wed Aug 23 10:26:59 UTC 2017


On 22/08/17 15:15, Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1712345
> 
> Whenever we update the ABI files, the files may be sorted in a different
> order, even though their contents are the same. That happens because the
> system updating the ABI files may use a different locale than the one
> that was used previously.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>
> ---
>  debian/scripts/misc/getabis | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/debian/scripts/misc/getabis b/debian/scripts/misc/getabis
> index 2aad5ddf392a..c7a0c5fe2321 100755
> --- a/debian/scripts/misc/getabis
> +++ b/debian/scripts/misc/getabis
> @@ -1,5 +1,7 @@
>  #!/bin/bash
>  
> +export LC_ALL=C.UTF-8
> +
>  if [ "$#" != "2" ]; then
>  	echo "Usage: $0 <release> <revision>" 1>&2
>  	exit 1
> 
Seems very reasonable to me.

Acked-by: Colin Ian King <colin.king at canonical.com>




More information about the kernel-team mailing list