ACK/cmnt: [SRU][Xenial][PATCH] net: cdc_mbim: apply "NDP to end" quirk to,HP lt4132

[Kleber Souza]

On 08/17/17 13:16, Aurimas Fišeras wrote:
> BugLink: https://bugs.launchpad.net/bugs/1707643
> 
> The HP lt4132 LTE/HSPA+ 4G Module (03f0:a31d) is a rebranded Huawei
> ME906s-158 device. It, like the ME906s-158, requires the "NDP to end"
> quirk for correct operation.
> 
> OriginalAuthor: Tore Anderson <tore at fud.no>
> Signed-off-by: Tore Anderson <tore at fud.no>
> Signed-off-by: David S. Miller <davem at davemloft.net>
> (cherry-picked from commit a68491f895a937778bb25b0795830797239de31f)
> Signed-off-by: Aurimas Fišeras <aurimas at members.fsf.org>
> Tested-by: Aurimas Fišeras <aurimas at members.fsf.org>
> 
> ---

Good testing results, clean cherry pick and small quirk affecting a
single device.

There are two small issues that can be fixed when applying the patch:
- Replace the comma (',') on the subject line by a white space.
- Use the author name/email from the 'OriginalAuthor:' tag as the
'From:' header so the commit author is correct.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>


>  drivers/net/usb/cdc_mbim.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/usb/cdc_mbim.c b/drivers/net/usb/cdc_mbim.c
> index 18fa45f..7220cd6 100644
> --- a/drivers/net/usb/cdc_mbim.c	2017-08-01 16:41:51.000000000 +0300
> +++ b/drivers/net/usb/cdc_mbim.c	2017-08-01 16:40:55.020912908 +0300
> @@ -626,6 +626,14 @@
>  	{ USB_VENDOR_AND_INTERFACE_INFO(0x12d1, USB_CLASS_COMM, USB_CDC_SUBCLASS_MBIM, USB_CDC_PROTO_NONE),
>  	  .driver_info = (unsigned long)&cdc_mbim_info_ndp_to_end,
>  	},
> +
> +	/* The HP lt4132 (03f0:a31d) is a rebranded Huawei ME906s-158,
> +	 * therefore it too requires the above "NDP to end" quirk.
> +	 */
> +	{ USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0xa31d, USB_CLASS_COMM, USB_CDC_SUBCLASS_MBIM, USB_CDC_PROTO_NONE),
> +	  .driver_info = (unsigned long)&cdc_mbim_info_ndp_to_end,
> +	},
> +
>  	/* default entry */
>  	{ USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MBIM, USB_CDC_PROTO_NONE),
>  	  .driver_info = (unsigned long)&cdc_mbim_info_zlp,
>