NACK [PULL][Xenial] Add OpenNSL to Xenial Kernel

[Andy Whitcroft]

On Fri, Aug 04, 2017 at 06:33:27PM +0800, Wen-chien Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1665783
> 
> These patchaesi, based on rtg's previous work, merge OpenNSL into ubuntu/.
> OpenNSL modules will only be enabled in amd64 build only.
> 
> Please note the version merged at this point is v3.1.0.17 (SDK 6.4.10)
> instead of the latest one due to project requirement. Will move to the
> latest release at some point later.

It would be really helpful to describe what it is one is attempting with
this pull request here in the initial email.  The bug has lots of how
and why but I was confused at this point.

>  ubuntu/opennsl/OpenNSL/Legal/LICENSE-Adv           |  149 +
>  ubuntu/opennsl/OpenNSL/Legal/LICENSE-Apache2       |  174 +

I believe that the Apache license here is ok and likely is
co-minglable with the GPLv2 though I would need to confirm that.  The
Adv license however does look to be incompatible with redistribution:

	License Limitations - Licensee will not:

	a. Sell, rent, lease, distribute, sublicense, assign, or
	otherwise transfer (including by loan or gift) the Code,
	or any full or partial copies thereof;

There are cirtainly files solely under this licence included:

	include/opennsl/cosqX.h: *
	include/opennsl/errorX.h: *
	include/opennsl/fieldX.h: *
	include/opennsl/initX.h: *
	include/opennsl/knetX.h: *
	include/opennsl/l2X.h: *
	include/opennsl/l3X.h: *
	include/opennsl/linkX.h: *
	include/opennsl/mirrorX.h: *
	include/opennsl/mplsX.h: *
	include/opennsl/multicastX.h: *
	include/opennsl/pktX.h: *
	include/opennsl/policerX.h: *
	include/opennsl/portX.h: *
	include/opennsl/qosX.h: *
	include/opennsl/rxX.h: *
	include/opennsl/stackX.h: *
	include/opennsl/statX.h: *
	include/opennsl/stgX.h: *
	include/opennsl/switchX.h: *
	include/opennsl/trunkX.h: *
	include/opennsl/tunnelX.h: *
	include/opennsl/txX.h: *
	include/opennsl/typesX.h: *
	include/opennsl/vlanX.h: *
	include/opennsl/vxlanX.h: *

>  .../OpenNSL/doc/html/BRCM_Red+Black_noTag_RGB.png  |  Bin 0 -> 10088 bytes
>  .../OpenNSL/doc/html/OPENNSL_API_OVERVIEW.html     |   94 +
>  .../OpenNSL/doc/html/OPENNSL_BST_OVERVIEW.html     |   73 +
>  .../opennsl/OpenNSL/doc/html/OPENNSL_BUILDING.html |  132 +
[...]

There is probabally little value in including the documentation
in the kernel itself and it comes to some 600 files we never seem
to use.

>  create mode 100644 ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/RELEASE

This file seems to be empty?

The licencing issues look on the face of it fatal to inclusion.

-apw