[kteam-tools PATCH] verify-release-ready: fix for new style of release tb

[Kleber Souza]

On 04/28/2017 05:39 AM, Po-Hsu Lin (Sam) wrote:
> On Fri, Apr 28, 2017 at 12:53 AM, Kleber Sacilotto de Souza
> <kleber.souza at canonical.com> wrote:
>> The check for the 'release tracking bug' was looking only for the old
>> style tracking bug on the changelog:
>>
>>   * Release Tracking Bug
>>     - LP: #<lp number>
>>
>> Change it catch also the new style:
>>
>>   * linux: <version> -proposed tracker (LP: #<lp number>)
>>
>> Signed-off-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
>> ---
>>  maintscripts/verify-release-ready | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
>> index 7413cab5..1fd34a9d 100755
>> --- a/maintscripts/verify-release-ready
>> +++ b/maintscripts/verify-release-ready
>> @@ -215,6 +215,8 @@ class VerifyReleaseReady():
>>          #
>>          found_tracker = False
>>          for line in changelog[1]['content']:
>> +            if '-proposed tracker' in line:
>> +                found_tracker = True
> 
> I think it's better to group the old if statement for 'Tracking Bug':
>             if 'Tracking Bug' in line:
>                 found_tracker = True
> alongside this new one, since they serve the same purpose.

It's not just grouping the if's, since it would break the logic. But I
agree, the code can be more elegant (this was a quick fix after a long
day). I will work on a v2.


Thanks!

> 
>>              if found_tracker:
>>                  if '#' in line:
>>                      (junk, tracker_id) = line.split('#')
>> --
>> 2.11.0
>>
>>
>> --
>> kernel-team mailing list
>> kernel-team at lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team

-- 
Kleber Souza
Linux Kernel Engineer
Canonical Ltd.