[PULL][Zesty] Low-pin-count (LPC) controller support for arm64

dann frazier dann.frazier at canonical.com
Mon Apr 24 21:39:08 UTC 2017

On Mon, Apr 24, 2017 at 8:20 AM, Seth Forshee
<seth.forshee at canonical.com> wrote:
> On Thu, Apr 20, 2017 at 03:23:33PM -0600, dann frazier wrote:
>> Here's an updated PR that increases the buffer size to match the
>> length attribute which, as you noted off-list, follows a pattern used
>> elsewhere in the kernel. I've also provided this feedback in a review
>> of the current LPC patch series.
>> The following changes since commit 815d83d7188878caeaff28a15be14a8d676dc045:
>>   Linux 4.10.10 (2017-04-12 07:26:53 -0600)
>> are available in the git repository at:
>>   git://git.launchpad.net/~dannf/ubuntu/+source/linux/+git/linux lpc-20170420
>> for you to fetch changes up to 2ff710b9447e5e50533970c5740189fbf1fff58a:
>>   UBUNTU: SAUCE: LIBIO: Make the size of the acpi_resource buffer
>> match it's length property (2017-04-20 15:20:19 -0600)
> Sorry for the delay in getting this review back to you.
> One thing you might want to consider. I note that in the latest upstream
> submission this has changed from libio to some other name. Adopting what
> will (presumably) be the name used upstream might make it less
> cumbersome when you need to backport future changes.

The name has changed a few times already (extio->libio->logic pio),
and I'm not confident the last one will stick either. The current name
was not one of the ones upstream suggested, and it hasn't been ACK'd
yet. My preference would therefore be to merge as-is, unless you feel
strongly otherwise.

> At this point though this looks safe enough to merge.
> - Minimal impact to non-arm64 architectures
> - New drivers will only be used on relevant platforms, so no impact on
>   other arm64 platforms from those drivers
> - Impact to other arm64 platforms is kept as minimal as possible
> - Smoke testing against other architectures and platforms
> Acked-by: Seth Forshee <seth.forshee at canonical.com>



More information about the kernel-team mailing list