ACK/cmnt: [PATCH] ubuntu_kernel_selftests: fix libnuma-dev install for s390x

[Stefan Bader]

On 21.04.2017 11:46, Kleber Sacilotto de Souza wrote:
> After commit 27a538cb64541c30cfb0b1e9cc42e1d03d0f5e30
> (ubuntu_kernel_selftests: net tests require libnuma-dev), all
> ubuntu_kernel_selftests are failing for s390x on series earlier than
> Yakkety, since libnuma-dev is being built only from this series on.
> 
> Fix it by not installing the package when running older series on s390x.
> Net tests are expected to continue failing though.
> 
> Signed-off-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
> ---
>  ubuntu_kernel_selftests/ubuntu_kernel_selftests.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
> index 30e045df..2910fe29 100644
> --- a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
> +++ b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
> @@ -12,8 +12,10 @@ class ubuntu_kernel_selftests(test.test):
>          series = platform.dist()[2]
>  
>          pkgs = [
> -            'build-essential', 'git', 'libnuma-dev'
> +            'build-essential', 'git'
>          ]
> +        if not (arch == 's390x' and series in ['precise', 'trusty', 'vivid', 'xenial']):
> +            pkgs.append('libnuma-dev')

Strictly speaking there is no s390x before Xenial but that is ok.

-Stefan

>          gcc = 'gcc' if arch in ['ppc64le', 'aarch64', 's390x'] else 'gcc-multilib'
>          pkgs.append(gcc)
>  
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20170421/d5fb6bb6/attachment.sig>