ACK w/cmt: [PATCH Yakkety SRU 1/1] net: fix incorrect original ingress device index in PKTINFO

Jorge Niedbalski jorge.niedbalski at canonical.com
Thu Apr 20 22:43:31 UTC 2017


Hello Seth,

On Thu, Apr 20, 2017 at 6:44 PM, Seth Forshee
<seth.forshee at canonical.com> wrote:
> On Thu, Apr 20, 2017 at 06:02:33PM -0300, jorge.niedbalski at canonical.com wrote:
>> From: Wei Zhang <asuka.com at 163.com>
>>
>> When we send a packet for our own local address on a non-loopback
>> interface (e.g. eth0), due to the change had been introduced from
>> commit 0b922b7a829c ("net: original ingress device index in PKTINFO"), the
>> original ingress device index would be set as the loopback interface.
>> However, the packet should be considered as if it is being arrived via the
>> sending interface (eth0), otherwise it would break the expectation of the
>> userspace application (e.g. the DHCPRELEASE message from dhcp_release
>> binary would be ignored by the dnsmasq daemon, since it come from lo which
>> is not the interface dnsmasq bind to)
>>
>> Fixes: 0b922b7a829c ("net: original ingress device index in PKTINFO")
>> Acked-by: David Ahern <dsa at cumulusnetworks.com>
>> Signed-off-by: Wei Zhang <asuka.com at 163.com>
>> Signed-off-by: David S. Miller <davem at davemloft.net>
>> Signed-off-by: Jorge Niedbalski <jorge.niedbalski at canonical.com>
>
> Patch is fine, but needs to include the buglink and the "(cherry picked
> from ...)" line in the commit message. Passing -x to git cherry-pick
> will get you the latter.
>
> With those added:
>
> Acked-by: Seth Forshee <seth.forshee at canonical.com>

Thanks for reviewing, addressed your comments as part of
[PATCH v2 Yakkety SRU 1/1] net: fix incorrect original ingress device
index in PKTINFO

-- 
Jorge Niedbalski R.
STS - Engineering Team




More information about the kernel-team mailing list