NACK: [Xenial] [PATCH 1/1] thermal/powerclamp: remove cpu whitelist

Seth Forshee seth.forshee at
Mon Apr 10 15:43:15 UTC 2017

On Fri, Apr 07, 2017 at 03:21:27PM +0100, Kai-Heng Feng wrote:
> From: Jacob Pan <jacob.jun.pan at>
> BugLink:
> Powerclamp works by aligning idle time to achieve package level
> idle states, aka cstates. As long as one of the package cstates
> is available, synchronized idle injection is meaningful.
> This patch replaces the CPU whitelist with CPU feature and
> package cstate counter check such that we don't have to modify
> this whitelist for every new CPU.
> Signed-off-by: Jacob Pan <jacob.jun.pan at>
> Signed-off-by: Zhang Rui <rui.zhang at>
> (cherry picked from commit b721ca0d192754deccb89fb01c77e41e6fd91ad9)
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at>

It looks to me like there are some follow-up commits needed, one to fix
a bug in this patch (loading powerclamp on cpus which don't support it)
and another to fix a bug introduced by the previous fix.

3105f234e0ab thermal/powerclamp: correct cpu support check
ec638db8cb9d thermal/powerclamp: add back module device table


More information about the kernel-team mailing list