Fwd: New Defects reported by Coverity Scan for ubuntu-xenial-kernel

[Colin Ian King]

CoverityScan picked up the following new defects on xenial master-next

Colin

-------- Forwarded Message --------
Subject: New Defects reported by Coverity Scan for ubuntu-xenial-kernel
Date: Tue, 04 Apr 2017 01:23:14 -0700
From: scan-admin at coverity.com
To: colin.king at canonical.com


Hi,

Please find the latest report on new defect(s) introduced to
ubuntu-xenial-kernel found with Coverity Scan.

2 new defect(s) introduced to ubuntu-xenial-kernel found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1423985:  Resource leaks  (RESOURCE_LEAK)
/fs/ext4/crypto_key.c: 247 in ext4_get_encryption_info()


________________________________________________________________________________________________________
*** CID 1423985:  Resource leaks  (RESOURCE_LEAK)
/fs/ext4/crypto_key.c: 247 in ext4_get_encryption_info()
241     	res = crypto_ablkcipher_setkey(ctfm, raw_key,
242     				       ext4_encryption_key_size(mode));
243     	if (res)
244     		goto out;
245     246     	if (cmpxchg(&ei->i_crypt_info, NULL, crypt_info) == NULL)
>>>     CID 1423985:  Resource leaks  (RESOURCE_LEAK)
>>>     Overwriting "crypt_info" in "crypt_info = NULL" leaks the storage that "crypt_info" points to.
247     		crypt_info = NULL;
248     out:
249     	if (res == -ENOKEY)
250     		res = 0;
251     	key_put(keyring_key);
252     	ext4_free_crypt_info(crypt_info);

** CID 1423986:  Resource leaks  (RESOURCE_LEAK)
/fs/f2fs/crypto_key.c: 225 in f2fs_get_encryption_info()


________________________________________________________________________________________________________
*** CID 1423986:  Resource leaks  (RESOURCE_LEAK)
/fs/f2fs/crypto_key.c: 225 in f2fs_get_encryption_info()
219     	res = crypto_ablkcipher_setkey(ctfm, raw_key,
220     					f2fs_encryption_key_size(mode));
221     	if (res)
222     		goto out;
223     224     	if (cmpxchg(&fi->i_crypt_info, NULL, crypt_info) == NULL)
>>>     CID 1423986:  Resource leaks  (RESOURCE_LEAK)
>>>     Overwriting "crypt_info" in "crypt_info = NULL" leaks the storage that "crypt_info" points to.
225     		crypt_info = NULL;
226     out:
227     	if (res == -ENOKEY && !S_ISREG(inode->i_mode))
228     		res = 0;
229     	key_put(keyring_key);
230     	f2fs_free_crypt_info(crypt_info);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZd8m-2BCYS83Gpc6CPaqTQF1BuJbaIOpuvdimoB-2BHggnuZROQR0-2FPNT-2Bmd1ckBYpOm4-3D_OFgvmg1J6naJevMotmPmRlTuZxP1uJqXcOMG9f4qAi4jhs7vTaK082srElc1Z6kAGbln5LJWDGwiwxazS5-2B4nFoPsjgMrOvbSx-2BPKGbsi4Vw4xfbOZR-2BOsauktYtdGekENmimYBh83i7iXIOL1nKez5ZkqoWW59P-2BV7M7nlflwkO4-2BX3Dc7rcUHvRI0N25wCagaL9bfzJMfsRIU6TDDyZnVdQ2Pz-2BGPfIbSeTWlhkAo-3D

To manage Coverity Scan email notifications for
"colin.king at canonical.com", click
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4B9nVBKVtwXiB4-2BdsKOQxbDQl0BcI5D9DhMHlVfgmixOEEI4TtjS4yCHzIkIbOF3ak-2BkflVDj0B1S6cLQhIOPZuGvnvI2bEt6aTZvzYSvWdc-3D_OFgvmg1J6naJevMotmPmRlTuZxP1uJqXcOMG9f4qAi4jhs7vTaK082srElc1Z6kAGbln5LJWDGwiwxazS5-2B4nMoIL1pYrzOughmVteHq5svRUuS6PoEwG85UjvuYB0IFnCoiegB-2BMzGht3RhN1smloHs0yIAMzfqwjFg-2FtnEgpFf7RdK-2Bpk-2BfvJ6twAbnnJNFBtLlIwP0uaJZBc-2F7w-2BOljFBqADU3lxT3OWHlpSzW-2FQ-3D