ACK: [yakkety/master-next 1/1] dm raid: fix compat_features validation

[Stefan Bader]

On 12.10.2016 11:12, Andy Whitcroft wrote:
> In ecbfb9f118bce4 ("dm raid: add raid level takeover support") a new
> compatible feature flag was added.  Validation for these compat_features
> was added but this only passes for new raid mappings with this feature
> flag.  This causes previously created raid mappings to be failed at
> import.
> 
> Check compat_features for the only valid combination.
> 
> Fixes: ecbfb9f118bce4 ("dm raid: add raid level takeover support")
> Cc: stable at vger.kernel.org # v4.8
> Signed-off-by: Andy Whitcroft <apw at canonical.com>
> Signed-off-by: Heinz Mauelshagen <heinzm at redhat.com>
> Signed-off-by: Mike Snitzer <snitzer at redhat.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1631298
> Signed-off-by: Andy Whitcroft <apw at canonical.com>
> ---
>  drivers/md/dm-raid.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
> index 8abde6b..2a39700 100644
> --- a/drivers/md/dm-raid.c
> +++ b/drivers/md/dm-raid.c
> @@ -2258,7 +2258,8 @@ static int super_validate(struct raid_set *rs, struct md_rdev *rdev)
>  	if (!mddev->events && super_init_validation(rs, rdev))
>  		return -EINVAL;
>  
> -	if (le32_to_cpu(sb->compat_features) != FEATURE_FLAG_SUPPORTS_V190) {
> +	if (le32_to_cpu(sb->compat_features) &&
> +	    le32_to_cpu(sb->compat_features) != FEATURE_FLAG_SUPPORTS_V190) {

Looks ok for no flag set and for the case of the one currently supported.

>  		rs->ti->error = "Unable to assemble array: Unknown flag(s) in compatible feature flags";
>  		return -EINVAL;
>  	}
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20161012/4b6b771f/attachment.sig>