ACK: [PATCH X/Y SRU] i40e: fix call of ndo_dflt_bridge_getlink()

Colin Ian King colin.king at canonical.com
Thu Nov 17 18:19:10 UTC 2016


On 17/11/16 18:16, Tim Gardner wrote:
> From: Huaibin Wang <huaibin.wang at 6wind.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1642519
> 
> Order of arguments is wrong.
> The wrong code has been introduced by commit 7d4f8d871ab1, but is compiled
> only since commit 9df70b66418e.
> 
> Note that this may break netlink dumps.
> 
> Fixes: 9df70b66418e ("i40e: Remove incorrect #ifdef's")
> Fixes: 7d4f8d871ab1 ("switchdev; add VLAN support for port's bridge_getlink")
> CC: Carolyn Wyborny <carolyn.wyborny at intel.com>
> Signed-off-by: Huaibin Wang <huaibin.wang at 6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel at 6wind.com>
> Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher at intel.com>
> (cherry picked from commit 599b076d15ee3ead7af20fc907079df00b2d59a0)
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index b484ab3..49d4050 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -8950,7 +8950,7 @@ static int i40e_ndo_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,
>  		return 0;
>  
>  	return ndo_dflt_bridge_getlink(skb, pid, seq, dev, veb->bridge_mode,
> -				       nlflags, 0, 0, filter_mask, NULL);
> +				       0, 0, nlflags, filter_mask, NULL);
>  }
>  
>  /* Hardware supports L4 tunnel length of 128B (=2^7) which includes
> 
Acked-by: Colin Ian King <colin.king at canonical.com>




More information about the kernel-team mailing list