[trusty, vivid][PATCH 1/1] proc: prevent accessing /proc/<PID>/environ until it's ready

Luis Henriques luis.henriques at canonical.com
Thu Nov 17 14:53:35 UTC 2016

From: Mathias Krause <minipli at googlemail.com>

If /proc/<PID>/environ gets read before the envp[] array is fully set up
in create_{aout,elf,elf_fdpic,flat}_tables(), we might end up trying to
read more bytes than are actually written, as env_start will already be
set but env_end will still be zero, making the range calculation
underflow, allowing to read beyond the end of what has been written.

Fix this as it is done for /proc/<PID>/cmdline by testing env_end for
zero.  It is, apparently, intentionally set last in create_*_tables().

This bug was found by the PaX size_overflow plugin that detected the
arithmetic underflow of 'this_len = env_end - (env_start + src)' when
env_end is still zero.

The expected consequence is that userland trying to access
/proc/<PID>/environ of a not yet fully set up process may get
inconsistent data as we're in the middle of copying in the environment

Fixes: https://forums.grsecurity.net/viewtopic.php?f=3&t=4363
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=116461
Signed-off-by: Mathias Krause <minipli at googlemail.com>
Cc: Emese Revfy <re.emese at gmail.com>
Cc: Pax Team <pageexec at freemail.hu>
Cc: Al Viro <viro at zeniv.linux.org.uk>
Cc: Mateusz Guzik <mguzik at redhat.com>
Cc: Alexey Dobriyan <adobriyan at gmail.com>
Cc: Cyrill Gorcunov <gorcunov at openvz.org>
Cc: Jarod Wilson <jarod at redhat.com>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
(cherry picked from commit 8148a73c9901a8794a50f950083c00ccf97d43b3)
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
 fs/proc/base.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 0d9205f3e5bf..4dd9d5541088 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -841,7 +841,8 @@ static ssize_t environ_read(struct file *file, char __user *buf,
 	int ret = 0;
 	struct mm_struct *mm = file->private_data;
-	if (!mm)
+	/* Ensure the process spawned far enough to have an environment. */
+	if (!mm || !mm->env_end)
 		return 0;
 	page = (char *)__get_free_page(GFP_TEMPORARY);

More information about the kernel-team mailing list