Disposition of 'UBUNTU: SAUCE: powerpc/eeh: Validate arch in eeh_add_device_early()'

Guilherme G. Piccoli gpiccoli at linux.vnet.ibm.com
Fri May 27 16:12:18 UTC 2016


On 05/16/2016 11:47 AM, Tim Gardner wrote:
> On 05/13/2016 07:30 AM, Guilherme G. Piccoli wrote:
>> On 05/12/2016 05:26 PM, Tim Gardner wrote:
>>> What is the upstream progress of this patch ? I'm not seeing any signs
>>> of it in linux-next either.
>>>
>>> http://kernel.ubuntu.com/git/rtg/ubuntu-unstable.git/commit/?h=SAUCE&id=28cb6ee7bbd0e127603673bc96d1048381a8b3e7
>>>
>>>
>>>
>>> rtg
>>
>> Hi Tim, this patch was 'evolved' in 2 patches, which were coincidentally
>> merged yesterday in powerpc next (they'll be released in upstream kernel
>> 4.7).
>>
>> The idea is to remove this SAUCE patch and add both patches below:
>>
>>
>> https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?id=c2078d9ef600bdbe568c89e5dd
>>
>>
>> https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?id=8445a87f7092bc8336ea1305be
>>
>>
>>
>> I guess they need to be added on kernels 4.2 (Ubuntu 15.10) and 4.4
>> (Ubuntu 16.04), and in all newer kernels from now on. Do you think it's
>> possible? I'm not sure the official procedures to this request, I
>> believe Breno can help us on this.
>>
>> Cheers,
>>
>>
>> Guilherme
>>
>
> I've dropped the SAUCE patch and cherry-picked the other 2 from
> linux-next. They should fall away during the 4.7 development cycle.
>
> rtg
>

Tim, unfortunately we found a bug in the 2nd patch, and the proposed fix 
is waiting Michael's review/approval on linuxppc-dev.

Link to the fix's patchwork: https://patchwork.ozlabs.org/patch/626492


Then, the 2nd commit (aka "powerpc/iommu: Remove the dependency on EEH 
struct in DDW mechanism") should only be added along with the fix, or 
we'll have trouble in enabling DDW windows.

The 1st commit (aka "Revert \"powerpc/eeh: Fix crash in 
eeh_add_device_early() on Cell\"" however can be added normally, since 
it's fine - in fact, the 1st commit is even more important than the 2nd 
(since it solves alone a variety of reported bugs).

I'm sorry for this, hope not to cause too much trouble for you.
Cheers,


Guilherme





More information about the kernel-team mailing list