[PATCH 2/2] ALSA: timer: Fix leak in events via snd_timer_user_tinterrupt
Luis Henriques
luis.henriques at canonical.com
Wed May 25 15:17:25 UTC 2016
From: Kangjie Lu <kangjielu at gmail.com>
The stack object “r1” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.
Signed-off-by: Kangjie Lu <kjlu at gatech.edu>
Signed-off-by: Takashi Iwai <tiwai at suse.de>
(cherry picked from commit e4ec8cc8039a7063e24204299b462bd1383184a5)
CVE-2016-4578
BugLink: https://bugs.launchpad.net/bugs/1581866
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
sound/core/timer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/core/timer.c b/sound/core/timer.c
index c72023235f0a..a82f82624247 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -1248,6 +1248,7 @@ static void snd_timer_user_tinterrupt(struct snd_timer_instance *timeri,
}
if ((tu->filter & (1 << SNDRV_TIMER_EVENT_RESOLUTION)) &&
tu->last_resolution != resolution) {
+ memset(&r1, 0, sizeof(r1));
r1.event = SNDRV_TIMER_EVENT_RESOLUTION;
r1.tstamp = tstamp;
r1.val = resolution;
More information about the kernel-team
mailing list