[Xenial][Pull] Add Qualcomm Atheros QCA9377 firmware
Seth Forshee
seth.forshee at canonical.com
Thu Jun 9 15:00:00 UTC 2016
On Wed, Jun 08, 2016 at 03:40:30PM +0800, Phidias Chiang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1484159
>
> The driver is ready for v4.4+ kernel and is included in Xenial
> release, but lacking of firmware to make it work. This pull
> request add the firmware from upstream, and has been tested.
>
> For Yakkety, the daily build release has already included the
> firmware, and releases before Xenial doesn't support the
> device so only Xenial need this.
This looks fine, but you missed a couple of details.
First, the bug link should be added to the commit message.
Second, you should be using the -x argument for 'git cherry-pick' to add
the "(cherry picked from ...)" line before your sign-off.
I'll fix up the commit message when apply it, but please try to remember
both of these in the future.
Thanks,
Seth
More information about the kernel-team
mailing list