ACK: [SRU][Trusty][lts-linux-trusty]Pull Request: Fixes for lp:1519897

[Joseph Salisbury]

On 01/22/2016 05:09 PM, Tim Gardner wrote:
> On 01/22/2016 02:02 PM, Joseph Salisbury wrote:
>> On 01/22/2016 03:43 PM, Tim Gardner wrote:
>>> The backport of 3a28fa35d6658703cd26f9c16aaea0eae06afd40 ('Drivers: hv:
>>> vmbus: Implement per-CPU mapping of relid to channel') has an extra
>>> unused variable added, e.g., include/linux/hyperv.h:
>>>
>>> +       /*
>>> +        * Support per-channel state for use by vmbus drivers.
>>> +        */
>>> +       void *per_channel_state;
>>>
>>> It is benign, but nonetheless consumes memory.
>>>
>>> Otherwise the backports look good, the rest are cherry picks, and no
>>> other subsystems are affected. Good test results.
>>>
>>> rtg
>> Thanks for the feedback, Tim. 
>>
>> That variable was added by the cherry pick to match what the patch was
>> expecting even though the patch didn't use it:
>>
>> Excerpt from original commit:
>>          * Support per-channel state for use by vmbus drivers.
>>          */
>>         void *per_channel_state;
>> +       /*
>> +        * To support per-cpu lookup mapping of relid to channel,
>> +        * link up channels based on their CPU affinity.
>> +        */
>> +       struct list_head percpu_list;
>>  };
>>
>>
>>
>>
>> Do you want me to send a new pull request with and updated patch to not
>> include that unused variable?
>>
>> Just curious how you found this, so I can add it to my process and not
>> do this again?  Did you discover this as a build warning, or do you
>> check the code for each new variable added?
>>
>> Thanks,
>>
>> Joe
>>
> I compared the original commit to your backport (which I generally do
> for backports). It just lept out at me.
>
> If you just fix it in place, I don't think you need to generate another
> pull request.
>
> rtg
Thanks again for the feedback, Tim.

I fixed it in place.  Repo to pull from is in the same location.

Thanks,

Joe