[SRU][Trusty][PATCH 0/2] Fixes for lp1525324.

Joseph Salisbury joseph.salisbury at canonical.com
Fri Jan 22 15:33:32 UTC 2016


BugLink: http://bugs.launchpad.net/bugs/1525324

== Trusty SRU Justification ==
kernel/bonding: wrong netlink messages when deleting a bonding interface.  A 
netlink message advertise that bond0 is deleted and after that two netlink 
messages are sent telling that bond0 exists again.

The first patch fixes ordering of rtnl notifications during unregister_netdevice
by moving RTM_DELLINK notification to until after ndo_uninit.

The second patch is a fix to a problem the first patch created.  The delayed 
rtmsg_ifinfo() also delayed call to fill_info(). This translated into asking the
driver to remove private state and then query it's private state. This
could have catastropic consequences.
 
Commit 56bfa7ee7 is in mainline as of 3.16-rc1 and commit 395eea6c is in 
mainline as of 3.19-rc1.  Both commits cherry pick cleanly. 


== Fixes ==
commit 56bfa7ee7c8892f1aa61797e4b8fec84b31d29b3
Author: Roopa Prabhu <roopa at cumulusnetworks.com>
Date:   Thu May 1 11:40:30 2014 -0700

    unregister_netdevice : move RTM_DELLINK to until after ndo_uninit

commit 395eea6ccf2b253f81b4718ffbcae67d36fe2e69
Author: Mahesh Bandewar <maheshb at google.com>
Date:   Wed Dec 3 13:46:24 2014 -0800

    rtnetlink: delay RTM_DELLINK notification until after ndo_uninit()


== Test Case ==
A test kernel was built with these patches and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.



Mahesh Bandewar (1):
  rtnetlink: delay RTM_DELLINK notification until after ndo_uninit()

Roopa Prabhu (1):
  unregister_netdevice : move RTM_DELLINK to until after ndo_uninit

 include/linux/rtnetlink.h |  5 +++++
 net/core/dev.c            |  8 +++++++-
 net/core/rtnetlink.c      | 25 +++++++++++++++++++++----
 3 files changed, 33 insertions(+), 5 deletions(-)

-- 
1.9.1





More information about the kernel-team mailing list