bug #1536076 - Missing export symbol for mtrr_add and mtrr_del

[Tim Gardner]

On 01/22/2016 03:41 AM, Alberto Milone wrote:
> On 21-01-16 16:28:08, Tim Gardner wrote:
>> Alberto - I've applied a patch to Xenial master-next to export these
>> symbols, but I'm wondering how fglrx ever worked for Linux 4.3 ?
>>
> 
> Hi Tim,
> 
> I am pretty sure fglrx works with 4.3. Also, I tested fglrx with 4.4
> (from the kernel team PPA) before my last upload. I have just booted the
> same system, just to double check, and I can't see any related errors in
> dmesg:
> 
> :~$ uname -r
> 4.4.0-0-generic
> 
> :~$ dkms status
> fglrx-core, 15.201, 4.3.0-2-generic, x86_64: installed
> fglrx-core, 15.201, 4.4.0-0-generic, x86_64: installed
> 
> 
> :~$ apt-cache policy linux-image-4.4.0-0-generic
> linux-image-4.4.0-0-generic:
>   Installed: 4.4.0-0.11
>   Candidate: 4.4.0-0.11
>   Version table:
>  *** 4.4.0-0.11 0
>         100 /var/lib/dpkg/status
> 
> :~$ apt-cache policy fglrx
> fglrx:
>   Installed: 2:15.201-0ubuntu6
>   Candidate: 2:15.201-0ubuntu6
>   Version table:
>  *** 2:15.201-0ubuntu6 0
>         500 http://it.archive.ubuntu.com/ubuntu/ xenial/restricted amd64 Packages
>         100 /var/lib/dpkg/status
> 
> dmesg output:
> http://paste.ubuntu.com/14596870/
> 
>> Do you think this is the right thing to do ?
>>
>> rtg
> 
> My patch for Linux 4.3 replaces mtrr_add with arch_phys_wc_add, and
> mtrr_del with arch_phys_wc_del. I don't think we need to add any symbols
> to the kernel.
> 
> I suspect the user who reported the problem is using the upstream fglrx
> packages, which do not include any kernel patches.
> 
> Regards,
> 
> --
> Alberto Milone
> Software Engineer
> Hardware Enablement Team
> Professional and Engineering Services
> 

Works for me. I saw that patch, but must have been dyslexic about when
it is applied to which version. I'll drop the mtrr export patch from Xenial.

rtg
-- 
Tim Gardner tim.gardner at canonical.com