[PATCH] required_logs.py: add "please run an Ubuntu kernel" verbiage

Kamal Mostafa kamal at canonical.com
Thu Jan 14 19:03:40 UTC 2016


This seems like a reasonable idea to me.  Here's the proposed patch for
consideration by the rest of the team.  I slightly changed the wording of the
new text, to:

    While running an Ubuntu kernel (not a mainline or third-party kernel)
    please enter the following command in a terminal window:

 -Kamal

-----8<-----

From: "Christopher M. Penalver" <christopher.m.penalver at gmail.com>

Given the apport infrastructure hasn't been designed to provide helpful
information when apport-collect'ing with a mainline kernel, explicitly
mention running an Ubuntu kernel.

Signed-off-by: Christopher M. Penalver <christopher.m.penalver at gmail.com>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 bugs/bug_handlers/required_logs.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bugs/bug_handlers/required_logs.py b/bugs/bug_handlers/required_logs.py
index 672180d..7c611ec 100644
--- a/bugs/bug_handlers/required_logs.py
+++ b/bugs/bug_handlers/required_logs.py
@@ -33,7 +33,7 @@ class RequiredLogs(BugHandler):
     def __init__(self, cfg, lp, vout):
         BugHandler.__init__(self, cfg, lp, vout)
 
-        self.comment = "This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:\n\napport-collect %s\n\nand then change the status of the bug to 'Confirmed'.\n\nIf, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.\n\nThis change has been made by an automated script, maintained by the Ubuntu Kernel Team."
+        self.comment = "This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:\n\napport-collect %s\n\nand then change the status of the bug to 'Confirmed'.\n\nIf, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.\n\nThis change has been made by an automated script, maintained by the Ubuntu Kernel Team."
         self.comment_subject = "Missing required logs."
         self.confirm_subject = "Status changed to Confirmed"
         self.confirm_body = "This change was made by a bot."
-- 
1.9.1





More information about the kernel-team mailing list