[SRU wily,trusty] LP#1540586 -- hv_set_ifconfig brokeness

[Stefan Bader]

On 17.02.2016 12:07, Andy Whitcroft wrote:
> We have a whole raft of issues in our hv_set_ifconfig script (which is used
> by the kv_kvp_daemon to configure networking as requested by the host).
> Not least of which is that we totally misshandle the netmask parameter
> which leads to broken networking where the netmask does not match the
> default.
> 
> Following this email are three patches which bring the state of this
> script up to that used in Xenial.  This script has been tested by the
> original reporter on Trusty and Wily.  This is all all applied to Xenial.
> The second patch in the sequence is an automated reindent patch and
> contains no functional change; python3 is much more picky about indentation
> in particular to tab/space mixes which this script was full.
> 
> Proposing this for SRU to Trusty and Wily.

I find the patches a bit to large for a proper functional review, however since
they all target the same very special script, I would accept successful testing
there as a reason to ACK.

Just one question, was pytho3 also installed by default back in T or would there
be a possibility that the package there needs some dependency added (or maybe
that is all handled by dh_magic)...?

-Stefan
> 
> It should be noted that our azure images do not use this mechanism to
> configure networking so they should not be affected by any fallout from
> this change.  Though it would be prudent to request cloud testing with
> the kernel which has this applied when it hits -proposed.
> 
> -apw
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20160217/79658fc3/attachment.sig>