ACK: [PATCH Wily SRU] UBUNTU: SAUCE: IB/IPoIB: Do not set skb truesize since using one linearskb

Brad Figg brad.figg at canonical.com
Thu Feb 11 18:02:55 UTC 2016


On Thu, Feb 04, 2016 at 01:06:27PM -0700, tim.gardner at canonical.com wrote:
> From: Carol L Soto <clsoto at linux.vnet.ibm.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1541326
> 
> This patch is being upstreamed.
> 
> We are seeing this warning: at net/core/skbuff.c:4174
> and before commit a44878d10063 ("IB/ipoib: Use one linear skb in RX flow")
> skb truesize was not being set when ipoib was using just one skb.
> Removing this line avoids the warning when running tcp tests like iperf.
> 
> Fixes: a44878d10063 ("IB/ipoib: Use one linear skb in RX flow")
> Signed-off-by: Carol L Soto <clsoto at linux.vnet.ibm.com>
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---
>  drivers/infiniband/ulp/ipoib/ipoib_ib.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
> index d266667..b5a851f 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
> @@ -245,8 +245,6 @@ static void ipoib_ib_handle_rx_wc(struct net_device *dev, struct ib_wc *wc)
>  	skb_reset_mac_header(skb);
>  	skb_pull(skb, IPOIB_ENCAP_LEN);
>  
> -	skb->truesize = SKB_TRUESIZE(skb->len);
> -
>  	++dev->stats.rx_packets;
>  	dev->stats.rx_bytes += skb->len;
>  
> -- 
> 2.7.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team


-- 
Brad Figg brad.figg at canonical.com http://www.canonical.com




More information about the kernel-team mailing list