[PATCH 3.16.y-ckt 154/180] kconfig: return 'false' instead of 'no' in bool function

Luis Henriques luis.henriques at canonical.com
Wed Feb 3 22:32:40 UTC 2016


3.16.7-ckt24 -stable review patch.  If anyone has any objections, please let me know.

---8<------------------------------------------------------------

From: Vegard Nossum <vegard.nossum at oracle.com>

commit aab24a897cfba9dd371f6aac45dbcdae0b23def6 upstream.

menu_is_visible() is a bool function and should use boolean return
values. "no" is a tristate value which happens to also have a value
of 0, but we should nevertheless use the right symbol for it.

This is a very minor cleanup with no semantic change.

Fixes: 86e187ff9 ("kconfig: add an option to determine a menu's visibility")
Cc: Arnaud Lacombe <lacombar at gmail.com>
Cc: Mauro Carvalho Chehab <mchehab at redhat.com>
Signed-off-by: Vegard Nossum <vegard.nossum at oracle.com>
Signed-off-by: Michal Marek <mmarek at suse.com>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
 scripts/kconfig/menu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 72c9dba84c5d..876c45d756d0 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -477,7 +477,7 @@ bool menu_is_visible(struct menu *menu)
 
 	if (menu->visibility) {
 		if (expr_calc_value(menu->visibility) == no)
-			return no;
+			return false;
 	}
 
 	sym = menu->sym;




More information about the kernel-team mailing list