[SRU][Xenial][PATCH 4/4] ovs/geneve: fix rtnl notifications on iface deletion

Joseph Salisbury joseph.salisbury at canonical.com
Thu Dec 8 15:06:05 UTC 2016


From: Nicolas Dichtel <nicolas.dichtel at 6wind.com>

BugLink: http://bugs.launchpad.net/bugs/1593235

The function geneve_dev_create_fb() (only used by ovs) never calls
rtnl_configure_link(). The consequence is that dev->rtnl_link_state is
never set to RTNL_LINK_INITIALIZED.
During the deletion phase, the function rollback_registered_many() sends
a RTM_DELLINK only if dev->rtnl_link_state is set to RTNL_LINK_INITIALIZED.

Fixes: e305ac6cf5a1 ("geneve: Add support to collect tunnel metadata.")
CC: Pravin B Shelar <pshelar at nicira.com>
CC: Jesse Gross <jesse at nicira.com>
CC: Thomas Graf <tgraf at suug.ch>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel at 6wind.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
(cherry picked from commit 41009481b690493c169ce85f591b9d32c6fd9422)
Signed-off-by: Joseph Salisbury <joseph.salisbury at canonical.com>
---
 drivers/net/geneve.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 82ebfee..0f50f07 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -1465,6 +1465,10 @@ struct net_device *geneve_dev_create_fb(struct net *net, const char *name,
 	if (err)
 		goto err;
 
+	err = rtnl_configure_link(dev, NULL);
+	if (err < 0)
+		goto err;
+
 	return dev;
 
  err:
-- 
2.7.4





More information about the kernel-team mailing list