[PATCH 2/5] HID: alps: struct u1_dev *priv is internal to the driver

Ying-Chun Liu (PaulLiu) paul.liu at canonical.com
Fri Aug 26 09:19:35 UTC 2016

From: Jiri Kosina <jkosina at suse.cz>

... and therefore should be marked static.

BugLink: https://bugs.launchpad.net/bugs/1616813

Signed-off-by: Jiri Kosina <jkosina at suse.cz>
(cherry picked from commit 41f61ecc501ca970ae8d9955c57405dc4abfab5a)
Signed-off-by: Ying-Chun Liu (PaulLiu) <paul.liu at canonical.com>
 drivers/hid/hid-alps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index b79c318..098bce6 100644
--- a/drivers/hid/hid-alps.c
+++ b/drivers/hid/hid-alps.c
@@ -98,7 +98,7 @@ struct u1_dev {
 	u32	sp_btn_cnt;
-struct u1_dev *priv;
+static struct u1_dev *priv;
 static int u1_read_write_register(struct hid_device *hdev, u32 address,
 	u8 *read_val, u8 write_val, bool read_flag)

More information about the kernel-team mailing list