[PATCH] Fix ZPL miswrite of default POSIX ACL
Colin King
colin.king at canonical.com
Wed Apr 27 14:00:58 UTC 2016
From: Ned Bass <bass6 at llnl.gov>
BugLink: http://bugs.launchpad.net/bugs/1574801
Commit 4967a3e introduced a typo that caused the ZPL to store the
intended default ACL as an access ACL. Due to caching this problem
may not become visible until the filesystem is remounted or the inode
is evicted from the cache. Fix the typo and add a regression test.
Signed-off-by: Ned Bass <bass6 at llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1 at llnl.gov>
Signed-off-by: Chunwei Chen <tuxoko at gmail.com>
Closes #4520
(backport from 98f03691a4c08f38ca4538c468e9523f8e6b24be https://github.com/zfsonlinux/zfs.git)
(dropped redundant modifications to zfs tests, we don't have these)
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
zfs/module/zfs/zpl_xattr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/zfs/module/zfs/zpl_xattr.c b/zfs/module/zfs/zpl_xattr.c
index 6a1acd7..4200919 100644
--- a/zfs/module/zfs/zpl_xattr.c
+++ b/zfs/module/zfs/zpl_xattr.c
@@ -969,7 +969,7 @@ zpl_set_acl(struct inode *ip, int type, struct posix_acl *acl)
break;
case ACL_TYPE_DEFAULT:
- name = XATTR_NAME_POSIX_ACL_ACCESS;
+ name = XATTR_NAME_POSIX_ACL_DEFAULT;
if (!S_ISDIR(ip->i_mode))
return (acl ? -EACCES : 0);
break;
--
2.7.4
More information about the kernel-team
mailing list