Un-ACK!: LP#1571156: vbox: resync with 5.0.18-dfsg-2build1 V2

[Kamal Mostafa]

On Sun, Apr 24, 2016 at 12:35:05PM +0100, Andy Whitcroft wrote:
> On Fri, Apr 22, 2016 at 03:22:45PM -0700, Kamal Mostafa wrote:
> > This patch set breaks (already applied to xenial/master-next) breaks the
> > xenial packaging.  debuild -S -I -i   fails with:
> > 
> > dpkg-source: info: building linux using existing linux_4.4.0.orig.tar.gz
> > dpkg-source: info: building linux in linux_4.4.0-22.38.diff.gz
> > dpkg-source: error: cannot represent change to ubuntu/vbox/vboxvideo/r0drv:
> > dpkg-source: error:   new version is symlink to ../r0drv
> > dpkg-source: error:   old version is nonexistent
> > 
> > What say you, Andy?
> 
> This is a simple change in link content in the tree.  When that happens
> we have to rebuild the reconstruct file.  That is normally done as part
> of "fdr insertchanges", but testing before then can trip these.

But no, I wasn't testing this before "fdr insertchanges".  That failure
occured (still occurs!) *after* I ran insertchanges (which did indeed
insert an r0drv line into the reconstruct script -- the same line that
you added in b726fa4 -- but that does _not_ fix the failure!)
 

> I
> suspect it makes sense to include an "fdr autoreconstruct" in the update
> proceedure, which I will do next time.
> 
> Separatly I have rebuilt the reconstruct and pushed it to the tip of
> master-next.  It test built for me.  I would recommend we fold it into
> the update commit and push it.

The source package still still fails the same way for me.  Andy, note
that binary builds aren't the problem here (is that what you "test
built"?), its the source package build that fails:

[origin/master-next] d87ebd8 UBUNTU: [Packaging] vbox -- fix up reconstruct on update

$ git clean -fxd
$ fakeroot debian/rules clean
$ debuild -S -I -i

dpkg-source: info: building linux using existing linux_4.4.0.orig.tar.gz 
dpkg-source: info: building linux in linux_4.4.0-22.38.diff.gz 
dpkg-source: error: cannot represent change to ubuntu/vbox/vboxvideo/r0drv: 
dpkg-source: error:   new version is symlink to ../r0drv 
dpkg-source: error:   old version is nonexistent

(Running "fakeroot debian/rules insertchanges" before fdr clean makes no
difference).

 -Kamal