[SRU][Xenial][PATCH 0/4] Reverts for LP:1554003

[Joseph Salisbury]

On 04/11/2016 11:09 AM, Joseph Salisbury wrote:
> On 04/11/2016 10:53 AM, Stefan Bader wrote:
>> On 08.04.2016 21:24, Joseph Salisbury wrote:
>>> BugLink: http://bugs.launchpad.net/bugs/1554003
>>>
>>> = SRU Justification ==
>>> The Xenial 4.4.0-4 and newer kernels will not boot on a HP BL460c G7 servers.  This
>>> is due to commit cdb898c5.  However, to revert this commit, three other commits also 
>>> needed to be reverted.
>>>
>>> A bunch of qla2xxx patches were applied to Xenial for bug 1541456, including these 
>>> four.  I'm not sure how reverting these four patches will affect that bug.
>> I am a bit hesitant to ack. The dependant reverts sound all like improving cpu
>> affinity which would be something that likely has impact in performance. Did you
>> try to ask the qlogic developer? Maybe there is a way forward instead of the
>> revert(s)...
>>
>> -Stefan
> I'll ping upstream and see if there is an alternative to the reverts.
I received a proposed fix from upstream.  I'll have the fix tested and
SRU it if it fixes the bug without these reverts.


>
>
>>> == Fixes ==
>>> The followin four commits need to be reverted:
>>> commit 5327c7dbd1a7fd980608f44789076a636e5ee5fc
>>> Author: Quinn Tran <quinn.tran at qlogic.com>
>>> Date:   Wed Feb 10 18:59:14 2016 -0500
>>>
>>>     qla2xxx: use TARGET_SCF_USE_CPUID flag to indiate CPU Affinity
>>>
>>> commit 9095adaab8c1d82707e4e9961b6ad79b62f3361b
>>> Author: Quinn Tran <quinn.tran at qlogic.com>
>>> Date:   Wed Feb 10 18:59:13 2016 -0500
>>>
>>>     target/transport: add flag to indicate CPU Affinity is observed
>>>
>>> commit fb3269baf4ecc2ce6d17d4eb537080035bdf6d5b
>>> Author: Quinn Tran <quinn.tran at qlogic.com>
>>> Date:   Thu Dec 17 14:57:06 2015 -0500
>>>
>>>     qla2xxx: Add selective command queuing
>>>
>>> commit cdb898c52d1dfad4b4800b83a58b3fe5d352edde
>>> Author: Quinn Tran <quinn.tran at qlogic.com>
>>> Date:   Thu Dec 17 14:57:05 2015 -0500
>>>
>>>     qla2xxx: Add irq affinity notification
>>>
>>>
>>> == Test Case ==
>>> A test kernel was built with a revert of these four patches and tested by the original bug reporter.
>>> The bug reporter states the test kernel resolved the bug.
>>>
>>>
>>>
>>>
>>> Joseph Salisbury (4):
>>>   Revert "qla2xxx: use TARGET_SCF_USE_CPUID flag to indiate CPU
>>>     Affinity"
>>>   Revert "target/transport: add flag to indicate CPU Affinity is
>>>     observed"
>>>   Revert "qla2xxx: Add selective command queuing"
>>>   Revert "qla2xxx: Add irq affinity notification"
>>>
>>>  drivers/scsi/qla2xxx/qla_def.h         |  6 ---
>>>  drivers/scsi/qla2xxx/qla_isr.c         | 76 +---------------------------------
>>>  drivers/scsi/qla2xxx/qla_target.c      | 25 +----------
>>>  drivers/scsi/qla2xxx/tcm_qla2xxx.c     |  7 +---
>>>  drivers/target/target_core_transport.c | 11 +----
>>>  include/target/target_core_base.h      |  3 --
>>>  6 files changed, 5 insertions(+), 123 deletions(-)
>>>
>>
>>
>
>