ACK: [PATCH v2][P, T, U, V, W] UBUNTU: [debian] BugLink: close LP: bugs only for Launchpad urls

Colin Ian King colin.king at canonical.com
Mon Apr 4 16:29:03 UTC 2016


On 04/04/16 15:54, Kamal Mostafa wrote:
> Stefan is correct: needs more cowbell (backslash before ".net").  Cannot use
> "\.launchpad" though because "http://launchpad.net/bugs/NNNNNNN" is a valid
> format.
> 
> ---8<-------
> 
> Generate "LP: #NNNNNNN" bug-close changelog comments only for BugLink's
> which actually refer to Launchpad URL's, not other bug trackers.
> 
> Signed-off-by: Kamal Mostafa <kamal at canonical.com>
> Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---
>  debian/scripts/misc/git-ubuntu-log | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian/scripts/misc/git-ubuntu-log b/debian/scripts/misc/git-ubuntu-log
> index 2967d87..e227752 100755
> --- a/debian/scripts/misc/git-ubuntu-log
> +++ b/debian/scripts/misc/git-ubuntu-log
> @@ -194,7 +194,7 @@ sub changelog_input {
>  						$bugz{$k} = 1 if (($k ne '') and ($k =~ /[0-9]+/));
>  					}
>  				}
> -				elsif (/^ *BugLink: *http.*:\/\/.*\/([0-9]+)/i) {
> +				elsif (/^ *BugLink: *.*launchpad\.net\/.*\/([0-9]+)/i) {
>  					$bugz{$1} = 1;
>  				}
>  				elsif (/^ *(CVE-.*)/) {
> 
Looks good to me

Acked-by: Colin Ian King <colin.king at canonical.com>




More information about the kernel-team mailing list