[3.16.y-ckt stable] Patch "HID: cp2112: fix I2C_SMBUS_BYTE write" has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Mon Sep 28 17:20:16 UTC 2015


This is a note to let you know that I have just added a patch titled

    HID: cp2112: fix I2C_SMBUS_BYTE write

to the linux-3.16.y-queue branch of the 3.16.y-ckt extended stable tree 
which can be found at:

    http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-3.16.y-queue

This patch is scheduled to be released in version 3.16.7-ckt18.

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.16.y-ckt tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Luis

------

>From 3cb9567dd50451dc53d16c2af68a29ef6c0d03ae Mon Sep 17 00:00:00 2001
From: Ellen Wang <ellen at cumulusnetworks.com>
Date: Mon, 13 Jul 2015 15:23:54 -0700
Subject: HID: cp2112: fix I2C_SMBUS_BYTE write

commit 6d00d153f00097d259f86304e11858a50a1b8ad1 upstream.

When doing an I2C_SMBUS_BYTE write (one byte write, no address),
the data to be written is in "command" not "data->byte".

Signed-off-by: Ellen Wang <ellen at cumulusnetworks.com>
Acked-by: Wolfram Sang <wsa at the-dreams.de>
Reviewed-by: Antonio Borneo <borneo.antonio at gmail.com>
Signed-off-by: Jiri Kosina <jkosina at suse.com>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
 drivers/hid/hid-cp2112.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
index ffe69be882de..68d6d93cbec9 100644
--- a/drivers/hid/hid-cp2112.c
+++ b/drivers/hid/hid-cp2112.c
@@ -451,7 +451,7 @@ static int cp2112_xfer(struct i2c_adapter *adap, u16 addr,
 		if (I2C_SMBUS_READ == read_write)
 			count = cp2112_read_req(buf, addr, read_length);
 		else
-			count = cp2112_write_req(buf, addr, data->byte, NULL,
+			count = cp2112_write_req(buf, addr, command, NULL,
 						 0);
 		break;
 	case I2C_SMBUS_BYTE_DATA:




More information about the kernel-team mailing list