[3.19.y-ckt stable] Patch "ipmi/powernv: Fix minor locking bug" has been added to staging queue

Kamal Mostafa kamal at canonical.com
Tue Sep 8 18:42:41 UTC 2015


This is a note to let you know that I have just added a patch titled

    ipmi/powernv: Fix minor locking bug

to the linux-3.19.y-queue branch of the 3.19.y-ckt extended stable tree 
which can be found at:

    http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-3.19.y-queue

This patch is scheduled to be released in version 3.19.8-ckt7.

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.19.y-ckt tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Kamal

------

>From e376012d5fc09a6b8900052e19cb5abd283fc2ed Mon Sep 17 00:00:00 2001
From: Alistair Popple <alistair at popple.id.au>
Date: Fri, 10 Apr 2015 17:32:20 +1000
Subject: ipmi/powernv: Fix minor locking bug

commit ad1ed2a9dd4c435d6a3ce470211db9a8d107c3e0 upstream.

If ipmi_powernv_recv(...) is called without a current message it
prints a warning and returns. However it fails to release the message
lock causing the system to dead lock during any subsequent IPMI
operations.

This error path should never normally be taken unless there are bugs
elsewhere in the system.

Signed-off-by: Alistair Popple <alistair at popple.id.au>
Signed-off-by: Corey Minyard <cminyard at mvista.com>
Cc: Tim Gardner <tim.gardner at canonical.com>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 drivers/char/ipmi/ipmi_powernv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
index 79524ed..8753b0f 100644
--- a/drivers/char/ipmi/ipmi_powernv.c
+++ b/drivers/char/ipmi/ipmi_powernv.c
@@ -125,6 +125,7 @@ static int ipmi_powernv_recv(struct ipmi_smi_powernv *smi)
 	spin_lock_irqsave(&smi->msg_lock, flags);

 	if (!smi->cur_msg) {
+		spin_unlock_irqrestore(&smi->msg_lock, flags);
 		pr_warn("no current message?\n");
 		return 0;
 	}
--
1.9.1





More information about the kernel-team mailing list