[3.16.y-ckt stable] Patch "disabling oplocks/leases via module parm enable_oplocks broken for SMB3" has been added to staging queue

Kamal Mostafa kamal at canonical.com
Mon Oct 26 21:14:35 UTC 2015


This is a note to let you know that I have just added a patch titled

    disabling oplocks/leases via module parm enable_oplocks broken for SMB3

to the linux-3.16.y-queue branch of the 3.16.y-ckt extended stable tree 
which can be found at:

    http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-3.16.y-queue

This patch is scheduled to be released in version 3.19.8-ckt9.

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.16.y-ckt tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Kamal

------

>From 06814687ca5beccc8032917189e7f21eb3ca86bb Mon Sep 17 00:00:00 2001
From: Steve French <smfrench at gmail.com>
Date: Tue, 22 Sep 2015 09:29:38 -0500
Subject: disabling oplocks/leases via module parm enable_oplocks broken for
 SMB3

commit e0ddde9d44e37fbc21ce893553094ecf1a633ab5 upstream.

leases (oplocks) were always requested for SMB2/SMB3 even when oplocks
disabled in the cifs.ko module.

Signed-off-by: Steve French <steve.french at primarydata.com>
Reviewed-by: Chandrika Srinivasan <chandrika.srinivasan at citrix.com>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 fs/cifs/smb2ops.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index eab05e1..29be80b 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -50,9 +50,13 @@ change_conf(struct TCP_Server_Info *server)
 		break;
 	default:
 		server->echoes = true;
-		server->oplocks = true;
+		if (enable_oplocks) {
+			server->oplocks = true;
+			server->oplock_credits = 1;
+		} else
+			server->oplocks = false;
+
 		server->echo_credits = 1;
-		server->oplock_credits = 1;
 	}
 	server->credits -= server->echo_credits + server->oplock_credits;
 	return 0;
--
1.9.1





More information about the kernel-team mailing list