[PATCH 3.19.y-ckt 007/156] HID: cp2112: fix I2C_SMBUS_BYTE write

Kamal Mostafa kamal at canonical.com
Tue Oct 20 21:35:48 UTC 2015


3.19.8-ckt8 -stable review patch.  If anyone has any objections, please let me know.

------------------

From: Ellen Wang <ellen at cumulusnetworks.com>

commit 6d00d153f00097d259f86304e11858a50a1b8ad1 upstream.

When doing an I2C_SMBUS_BYTE write (one byte write, no address),
the data to be written is in "command" not "data->byte".

Signed-off-by: Ellen Wang <ellen at cumulusnetworks.com>
Acked-by: Wolfram Sang <wsa at the-dreams.de>
Reviewed-by: Antonio Borneo <borneo.antonio at gmail.com>
Signed-off-by: Jiri Kosina <jkosina at suse.com>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 drivers/hid/hid-cp2112.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
index a2dbbbe..55fd146 100644
--- a/drivers/hid/hid-cp2112.c
+++ b/drivers/hid/hid-cp2112.c
@@ -554,7 +554,7 @@ static int cp2112_xfer(struct i2c_adapter *adap, u16 addr,
 		if (I2C_SMBUS_READ == read_write)
 			count = cp2112_read_req(buf, addr, read_length);
 		else
-			count = cp2112_write_req(buf, addr, data->byte, NULL,
+			count = cp2112_write_req(buf, addr, command, NULL,
 						 0);
 		break;
 	case I2C_SMBUS_BYTE_DATA:
-- 
1.9.1





More information about the kernel-team mailing list