ACK/cmnt: [Vivid][SRU][PATCH] LP#1501187 Backport support for ACPI GPIO interrupts for i2c-hid devices v2

[Stefan Bader]

On 16.10.2015 10:20, Phidias Chiang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1501187
> 
> [Impact]
> 
> On some platforms HID over I2C uses GPIO interrupts instead of directly connected
> to the IO-APIC. Without ACPI GPIO interrupts support, i2c-hid can not find IRQ
> when probing the device, and shows the following message:
> 
> i2c_hid i2c-SYNA7508:00: Could not register for SYNA7508:00 interrupt, irq = -1, ret = -22
> i2c_hid: probe of i2c-SYNA7508:00 failed with error -22
> 
> So far we've found this issue on some SKL platforms, and one BSW platform.
> 
> [Fix]
> 
> There's a fix in mainline v4.1-rc1, which add the support for ACPI GPIO interrupts
> for i2c-hid module.
> 
> This patch set also contains another patch "HID: i2c-hid: The interrupt should be
> level sensitive" to avoid conflict
> 
> 
> Mika Westerberg (2):
>   HID: i2c-hid: The interrupt should be level sensitive
>   HID: i2c-hid: Add support for ACPI GPIO interrupts
> 
>  drivers/hid/i2c-hid/i2c-hid.c |   70 ++++++++++++++++++++++++++++++-----------
>  1 file changed, 51 insertions(+), 19 deletions(-)
> 
Technically looks ok. I would think the generic change from edge to level should
not cause regressions.
From a process point of view I would defer it to the stable team to decide
whether this is critical enough for enabling functionality in an old release or
declare Wily as HWE kernel for this.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20151016/b0d571ec/attachment.sig>