ACK: [SRU][Vivid][PATCH 0/3] i40e: Patch set required to resolve lp1497812

[Stefan Bader]

On 02.10.2015 10:42, Stefan Bader wrote:
> On 01.10.2015 18:37, Joseph Salisbury wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1497812
>>
>> == Vivid SRU Justification ==
>>
>> Using 3.19.0-28-generic #30~14.04.1-Ubuntu with stock i40e
>> driver version 2.2.2-k makes every 'non physical' MAC output
>> frame appear as copied back at input, as if the switch was
>> doing frame 'mirroring' (and/or hair-pinning).
>>
>> If SRIOV is enabled we need to be in VEB mode not VEPA mode at probe.
>>     This fixes an NPAR bug when SRIOV is enabled in the BIOS.
>>
>> == Fix ==
>>
>> commit fa11cb3d16a9b9b296a2b811a49faf1356240348
>> Author: Anjali Singhai Jain <anjali.singhai at intel.com>
>> Date:   Wed May 27 12:06:14 2015 -0400
>>
>>     i40e: Make sure to be in VEB mode if SRIOV is enabled at probe
>>
>>
>> This commit has the following two prerequisits:
>>
>> commit 51616018dd1b49d4974fff92669606e97080f954 (Required a backport)
>> Author: Neerav Parikh <neerav.parikh at intel.com>
>> Date:   Fri Feb 6 08:52:14 2015 +0000
>>
>>     i40e: Add support for getlink, setlink ndo ops
>>
>> commit fc60861e9b00388fd11d7995a60bf0b1e61dba93
>> Author: Anjali Singhai Jain <anjali.singhai at intel.com>
>> Date:   Fri May 8 15:35:57 2015 -0700
>>
>>     i40e: start up in VEPA mode by default
>>
>>
>> == Test Case ==
>>
>> A test kernel was built with these patches and tested by the original bug reporter.
>> The bug reporter states the test kernel resolved the bug.
> 
> The first prereq patch is rather large but at least it is mostly adding new
> functions and not changing old interfaces. Also limited to one specific driver
> and certain mode of operation. So hopefully not causing regressions.
> Successful testing as well.

I would like to take back my ack at least until we had time to make sure patch#1
is ok.

-Stefan

> 
> -Stefan
> 
>>
>>
>> Anjali Singhai Jain (2):
>>   i40e: start up in VEPA mode by default
>>   i40e: Make sure to be in VEB mode if SRIOV is enabled at probe
>>
>> Neerav Parikh (1):
>>   i40e: Add support for getlink, setlink ndo ops
>>
>>  drivers/net/ethernet/intel/i40e/i40e.h             |  11 +
>>  drivers/net/ethernet/intel/i40e/i40e_debugfs.c     |  14 +-
>>  drivers/net/ethernet/intel/i40e/i40e_fcoe.c        |  11 +-
>>  drivers/net/ethernet/intel/i40e/i40e_main.c        | 223 +++++++++++++++++++--
>>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |  15 +-
>>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h |   3 +-
>>  6 files changed, 252 insertions(+), 25 deletions(-)
>>
> 
> 
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20151002/962ea688/attachment.sig>