ACK/cmnt: [PATCH Vivid SRU] UBUNTU: [Config] CONFIG_RTC_DRV_XGENE=y for only arm64

[Stefan Bader]

On 30.09.2015 23:46, Andy Whitcroft wrote:
> On Wed, Sep 30, 2015 at 04:02:56PM +0200, Stefan Bader wrote:
> 
>>> I cannot think of why either method would have a tactical or strategic
>>> advantage. Therefore I went with the surgical approach so that the
>>> changes made were explicit. In my opinion, an ignore file obfuscates
>>> the solution.
>>>
>> I was somehow thinking along the lines of the contents of the modules list in
>> that abi directory represent the state of that upload. Which still had the
>> module(s). And the goal is to drop them with the next upload. That is why I
>> thought using ignore files to document the expected "will be missing on the next
>> build" might be better...
> 
> Removing them from the previous ABI makes that slightly inaccurate,
> but can correctly represent the modules only being missing in a subset
> of architectures/flavours.  Putting them in the main module.ignore list
> keeps the ABI accurate, but prevents detection of accidental changes in
> other flavours.

That is why I thought we had the arch variant of modules ignore. But the naming
was very confusing and I always had to look in some wiki document. But I don't
want to delay this further. If the stable people are ok with that inaccuracy
there is no reason I should not be. At the end of the day this takes away a
module (on other arches) which could not be used anyway.

-Stefan

> 
> -apw
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20151001/39316c3d/attachment.sig>