[Vivid][SRU][PATCH 3/4] HID: rmi: Disable scanning if the device is not a wake source
Phidias Chiang
phidias.chiang at canonical.com
Fri Nov 13 07:39:43 UTC 2015
From: Andrew Duggan <aduggan at synaptics.com>
BugLink: http://bugs.launchpad.net/bugs/1515503
Some touchpads are configured with firmware which continues to scan for
fingers at a minimal scan rate even after receiving the HID power sleep
command. This allows a finger touching the touchpad to genrate a wake
event. This patch ensures that scanning is disabled if the touchpad is
not a wake source and ensures scanning is enabled on resume.
Signed-off-by: Andrew Duggan <aduggan at synaptics.com>
Signed-off-by: Jiri Kosina <jkosina at suse.com>
(backported from commit 0925636042170e0b6716cd86635899c5f4258f69)
Signed-off-by: Phidias Chiang <phidias.chiang at canonical.com>
Reviewed-By: AceLan Kao <acelan.kao at canonical.com>
Conflicts:
drivers/hid/hid-rmi.c
---
drivers/hid/hid-rmi.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 55 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 7cdf7e9..b6aa7db1 100644
--- a/drivers/hid/hid-rmi.c
+++ b/drivers/hid/hid-rmi.c
@@ -33,6 +33,9 @@
#define RMI_READ_DATA_PENDING 1
#define RMI_STARTED 2
+#define RMI_SLEEP_NORMAL 0x0
+#define RMI_SLEEP_DEEP_SLEEP 0x1
+
enum rmi_mode_type {
RMI_MODE_OFF = 0,
RMI_MODE_ATTN_REPORTS = 1,
@@ -121,6 +124,8 @@ struct rmi_data {
struct hid_device *hdev;
unsigned long firmware_id;
+
+ u8 f01_ctrl0;
};
#define RMI_PAGE(addr) (((addr) >> 8) & 0xff)
@@ -504,9 +509,51 @@ static int rmi_raw_event(struct hid_device *hdev,
}
#ifdef CONFIG_PM
+static int rmi_set_sleep_mode(struct hid_device *hdev, int sleep_mode)
+{
+ struct rmi_data *data = hid_get_drvdata(hdev);
+ int ret;
+ u8 f01_ctrl0;
+
+ f01_ctrl0 = (data->f01_ctrl0 & ~0x3) | sleep_mode;
+
+ ret = rmi_write(hdev, data->f01.control_base_addr,
+ &f01_ctrl0);
+ if (ret) {
+ hid_err(hdev, "can not write sleep mode\n");
+ return ret;
+ }
+
+ return 0;
+}
+
+static int rmi_suspend(struct hid_device *hdev, pm_message_t message)
+{
+ if (!device_may_wakeup(hdev->dev.parent))
+ return rmi_set_sleep_mode(hdev, RMI_SLEEP_DEEP_SLEEP);
+
+ return 0;
+}
+
static int rmi_post_reset(struct hid_device *hdev)
{
- return rmi_set_mode(hdev, RMI_MODE_ATTN_REPORTS);
+ int ret;
+
+ ret = rmi_set_mode(hdev, RMI_MODE_ATTN_REPORTS);
+ if (ret) {
+ hid_err(hdev, "can not set rmi mode\n");
+ return ret;
+ }
+
+ if (!device_may_wakeup(hdev->dev.parent)) {
+ ret = rmi_set_sleep_mode(hdev, RMI_SLEEP_NORMAL);
+ if (ret) {
+ hid_err(hdev, "can not write sleep mode\n");
+ return ret;
+ }
+ }
+
+ return ret;
}
static int rmi_post_resume(struct hid_device *hdev)
@@ -704,6 +751,12 @@ static int rmi_populate_f01(struct hid_device *hdev)
data->firmware_id += info[2] * 65536;
}
+ ret = rmi_read(hdev, data->f01.control_base_addr, &data->f01_ctrl0);
+
+ if (ret) {
+ hid_err(hdev, "can not read f01 ctrl0\n");
+ return ret;
+ }
return 0;
}
@@ -1161,6 +1214,7 @@ static struct hid_driver rmi_driver = {
.input_mapping = rmi_input_mapping,
.input_configured = rmi_input_configured,
#ifdef CONFIG_PM
+ .suspend = rmi_suspend,
.resume = rmi_post_resume,
.reset_resume = rmi_post_reset,
#endif
--
1.7.9.5
More information about the kernel-team
mailing list