Ack/cmt: [Trusty/Utopic][PATCH] HID: multitouch: add support of clickpads

Seth Forshee seth.forshee at canonical.com
Wed May 20 14:56:57 UTC 2015


On Wed, May 20, 2015 at 01:57:09PM +0800, Adam Lee wrote:
> From: Benjamin Tissoires <benjamin.tissoires at redhat.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1456881
> 
> Touchpads that have only one button are called clickpads and should
> be advertised as such by the kernel.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires at redhat.com>
> Tested-by: Jason Ekstrand <jason at jlekstrand.net>
> Signed-off-by: Jiri Kosina <jkosina at suse.cz>
> (cherry picked from commit 015fdaa9f8edd89a456b3331088e1b77ebdad9d0)
> Signed-off-by: Adam Lee <adam.lee at canonical.com>

This seems fine. As noted on the bug there's also my patch "HID:
multitouch: Add support for button type usage" which does the same thing
via a different detection mechanism. It may be that one or the other
doesn't work for some machines, but until we have an example of such a
machine I think that taking either one is sufficient.

Acked-by: Seth Forshee <seth.forshee at canonical.com>




More information about the kernel-team mailing list