[Vivid][SRU][patch] drm/i915: remove intel_pipe_set_base() (v4)
Timo Aaltonen
tjaalton at ubuntu.com
Tue May 19 13:00:23 UTC 2015
On 24.04.2015 10:06, Timo Aaltonen wrote:
> On 22.04.2015 09:57, Zhang, Xiong Y wrote:
>> BugLink: _https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1446979_
>>
>> commit 455a68086d1dfb801ad7c867d5ca0ed0e0f758b0
>> Author: Gustavo Padovan <gustavo.padovan at collabora.co.uk>
>> Date: Mon Dec 1 15:40:11 2014 -0800
>>
>> drm/i915: remove intel_pipe_set_base() (v4)
>>
>> After some refactor intel_primary_plane_setplane() does the same
>> as intel_pipe_set_base() so we can get rid of it and replace the calls
>> with intel_primary_plane_setplane().
>>
>> v2: take Ville's comments:
>> - get the right arguments for update_plane()
>> - use drm_crtc_get_hv_timing()
>>
>> v3 (by Matt):
>> - Rebase to latest di-nightly codebase
>> - Use primary->funcs->update_plane() in __intel_set_mode()
>> - Use primary->funcs->disable_plane() in intel_crtc_disable()
>>
>> v4 (by Matt):
>> - Drop redundant calls to intel_crtc_wait_for_pending_flips() before
>> calling update_plane() (Ville)
>>
>> Signed-off-by: Gustavo Padovan <gustavo.padovan at collabora.co.uk>
>> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
>> Acked-and-mourned-by: Jesse Barnes <jbarnes at virtuousgeek.org>
>> Reviewed-by: Ander Conselvan de Oliveira
>> <ander.conselvan.de.oliveira at intel.com>
>> Signed-off-by: Daniel Vetter _daniel.vetter at ffwll.ch_
>> <mailto:daniel.vetter at ffwll.ch>
>
> I've tested this on Broadwell, so has my ACK.
As posted on LP, this caused a regression on GM45 which can't boot
anymore. Do you have suggestions as to what would fix that? This patch
is likely going to be reverted for now.
--
t
More information about the kernel-team
mailing list