ACK/cmnt: [Precise][PATCH 0/5] e1000e fixes for Intel 82579LM

[Stefan Bader]

On 31.03.2015 04:50, Rafael David Tinoco (Inaddy) wrote:
> From: Rafael David Tinoco <inaddy at ubuntu.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1425333
> 
> SRU Justification:
> 
> Impact: e1000e driver can lockup in machine HP Z210.
> Fix: All the patches were taken from upstream.
> Testcase: To use an HP Z210 machine and wait certain conditions.
> 
> Observations: Several fixes cherry-picked from upstream for fixing 
> problems with Intel 82579LM (reported for HP Z210 machines).
> 
> Cherry-picks:

Is probably minor but having a different order of patches here and the follow-up
individual patches is a bit confusing.
> 
> commit 77e61146c67765deae45faa7db088c64a9fbca00
> Author: David Ertman
> Date: Tue Apr 22 05:25:53 2014 +0000
> 
>     e1000e: Workaround for dropped packets in Gig/100 speeds on 82579
> 
> commit 36ceeb43cecaf98a488b94bb318a1f3dd5a87033
> Author: Bruce Allan
> Date: Tue Mar 20 03:47:47 2012 +0000
> 
>     e1000e: 82579 packet drop workaround

1+2 Look to be simple enough and doing what is claimed.

> 
> commit 92fe173391b3e0d0a7212fa8b9d72c8d61f31c26
> Author: Bruce Allan
> Date: Thu Apr 12 06:27:03 2012 +0000
> 
>     e1000e: issues in Sx on 82577/8/9
> 
> commit 90b82984a4ce689d7b1d7132e50bc61ac6f8b74f
> Author: Bruce Allan
> Date: Fri Dec 16 00:46:33 2011 +0000
> 
>     e1000e: update workaround for 82579 intermittently disabled during S0->Sx
> 
> commit 4d24136c8ea03ecfdb6b8256571da8b520b92d8b
> Author: Bruce Allan
> Date: Fri Dec 16 00:46:06 2011 +0000
> 
>     e1000e: 82579: workaround for link drop issue
> 
> Signed-off-by: Rafael David Tinoco (Inaddy) <inaddy at ubuntu.com>
> 

for the rest it is harder to estimate without more context. Though generally
seem to follow the claimed changes and look to be isolated to the ich8lan part
of the driver. That could isolate the range of regression testing needed.

Based on that ACK for the set. Btw, I added a Precise task for the bug and for
the SRU it might also be nice to add which release those patches where included.
One randomly picked one for example was 3.4.

-Stefan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20150331/96edcf81/attachment.sig>