[PATCH 3.13.y-ckt 70/80] gpio: sysfs: fix memory leak in gpiod_sysfs_set_active_low

Kamal Mostafa kamal at canonical.com
Thu Mar 19 22:35:58 UTC 2015

3.13.11-ckt17 -stable review patch.  If anyone has any objections, please let me know.


From: Johan Hovold <johan at kernel.org>

commit 49d2ca84e433dab854c7a866bc6add09cfab682d upstream.

Fix memory leak in the gpio sysfs interface due to failure to drop
reference to device returned by class_find_device when setting the
gpio-line polarity.

Fixes: 0769746183ca ("gpiolib: add support for changing value polarity
in sysfs")
Signed-off-by: Johan Hovold <johan at kernel.org>
Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
[ kamal: backport to 3.13-stable: applied to drivers/gpio/gpiolib.c ]
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 1dda7e6..e90efc0 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -942,7 +942,7 @@ int gpiod_sysfs_set_active_low(struct gpio_desc *desc, int value)
 	status = sysfs_set_active_low(desc, dev, value);
+	put_device(dev);

More information about the kernel-team mailing list