[Trusty/Utopic][PATCH 1/2] x86: thinkpad_acpi.c: fixed spacing coding style issue

Adam Lee adam.lee at canonical.com
Thu Mar 5 08:41:12 UTC 2015


On Tue, Mar 03, 2015 at 03:25:36PM +0800, Adam Lee wrote:
> On Mon, Mar 02, 2015 at 12:12:19PM +0000, Andy Whitcroft wrote:
> > On Mon, Mar 02, 2015 at 02:40:18PM +0800, Adam Lee wrote:
> > > From: Jan van den Berg <janvdberg at gmail.com>
> > > 
> > > BugLink: https://bugs.launchpad.net/bugs/1417915
> > > 
> > > Fixed 22 similar coding style issues: "ERROR: spaces required around that '?'"
> > 
> > I is not clear that is a good idea to take such a wide ranging
> > whitespace cleanup just to get a single line of context in the second
> > patch to match.
> > 
> > -apw
> 
> Yes, but there will be lots of patches for thinkpad_acpi in future
> because of the sutton project, does it make sense to backport this
> cleanup patch to avoid future context merging issues?
> 
> Feel free to NAK my proposal :)

Hi, Andy

How do you think? Should I submit another version?

-- 
Adam Lee




More information about the kernel-team mailing list