ACK: Ack w/cmnt: [VIVID] [PULL] UBUNTU: arm64: xgene-enet: add SGMII based 1GbE support for the second port

Ming Lei ming.lei at canonical.com
Tue Jun 23 01:22:24 UTC 2015


On Sun, Jun 21, 2015 at 5:25 PM, Tim Gardner <tim.gardner at canonical.com> wrote:
> On 06/19/2015 05:21 PM, Brad Figg wrote:
>>
>>
>> 1. All are clean cherry-picks.
>> 2. All are localized to apm/xgene
>> 3. Positive testing.
>>
>> Minor issue: patch 1/11 is a cherry-pick of
>> de7b5b3d790a2524c3f992d357983600635c441b and
>> not b0ab0afaebc88158c02755d2d9a09f1406c82406 which is what the patch says.
>>
>> Brad
>>
>
> I agree with Brad's assessment, though I have to wonder how you managed to
> substitute an erroneous SHA1 if you are _really_ using 'git cherry-pick -x'.
> I'll find it quite tedious if I now have to verify that _every_ patch is
> indeed a cherry-pick.

Brad and Tim, thanks for your so detailed review.

Sorry for the mistake, and the cherry pick tag has been fixed already, could
you pull that now?

Thanks,
Ming




More information about the kernel-team mailing list