[UTOPIC] [PULL] UBUNTU: fix Occasional crash in APM xgene enet driver
Ming Lei
ming.lei at canonical.com
Thu Jun 18 02:41:43 UTC 2015
On Wed, Jun 17, 2015 at 8:45 PM, Tim Gardner <tim.gardner at canonical.com> wrote:
> On 06/16/2015 08:42 PM, Ming Lei wrote:
>>
>> Hi Guys,
>>
>> The 3 patches in below tree fixed one crash in APM xgene enet
>> driver, please pull that:
>>
>> git://kernel.ubuntu.com/ming/ubuntu-utopic.git
>> arm64-net-backport
>>
>> Buglink:
>> http://bugs.launchpad.net/bugs/1425576
>>
>> 0129e83 drivers: net: xgene: fix: Out of order descriptor bytes read
>> b53da50 arch: Add lightweight memory barriers dma_rmb() and dma_wmb()
>> 5f34c79 arch: Cleanup read_barrier_depends() and comments
>>
>> Thanks,
>> Ming
>>
>
> Ming - those 2 arch patches are messing with some seriously fundamental
> behaviours. Wouldn't it be much safer to just open code the barrier in the
> xgene enet driver ? I am quite reluctant to merge a patch that affects every
> architecture and could have very subtle side effects.
Good idea, I have updated the tree and sent out the new request.
Thanks,
Ming
>
> rtg
> --
> Tim Gardner tim.gardner at canonical.com
More information about the kernel-team
mailing list