[SRU][Vivid][Wily][PATCH 1/1] storvsc: Set the SRB flags correctly when no data transfer is needed

Joseph Salisbury joseph.salisbury at canonical.com
Fri Jun 5 18:00:31 UTC 2015


From: "K. Y. Srinivasan" <kys at microsoft.com>

BugLink: http://bugs.launchpad.net/bugs/1439780

Set the SRB flags correctly when there is no data transfer.  Without this
change some IHV drivers will fail valid commands such as TEST_UNIT_READY.

Cc: <stable at vger.kernel.org>
Signed-off-by: K. Y. Srinivasan <kys at microsoft.com>
Reviewed-by: Long Li <longli at microsoft.com>
Signed-off-by: James Bottomley <JBottomley at Odin.com>
(cherry picked from commit dc45708ca9988656d706940df5fd102672c5de92)
Signed-off-by: Joseph Salisbury <joseph.salisbury at canonical.com>
---
 drivers/scsi/storvsc_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index bf8c5c1..75efaae 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1565,8 +1565,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 		break;
 	default:
 		vm_srb->data_in = UNKNOWN_TYPE;
-		vm_srb->win8_extension.srb_flags |= (SRB_FLAGS_DATA_IN |
-						     SRB_FLAGS_DATA_OUT);
+		vm_srb->win8_extension.srb_flags |= SRB_FLAGS_NO_DATA_TRANSFER;
 		break;
 	}
 
-- 
2.1.0





More information about the kernel-team mailing list