NACK: [Trusty/Utopic][PATCH 2/2] HID: multitouch: Add support for button type usage
Seth Forshee
seth.forshee at canonical.com
Tue Jun 2 18:34:34 UTC 2015
On Fri, May 29, 2015 at 10:03:36AM +0800, Adam Lee wrote:
> On Thu, May 28, 2015 at 07:48:23AM -0500, Seth Forshee wrote:
> > This doesn't make any sense to me. All of the detection done by this
> > patch happens when the device is probed, and once INPUT_PROP_BUTTONPAD
> > is set it shouldn't get cleared later due to heavy load. The device is
> > defined in the ACPI tables, so it's not going to be vanishing then
> > reappearing to be reprobed.
> >
> > So I'm skeptical that this patch really fixes the problem. Not that I
> > think it will do any harm, but I can't understand how it would possibly
> > help.
> >
> > Seth
>
> Thanks, Seth. Will paste your comment into launchpad and let's see the
> following updates. (I don't have the physical access to that machine
If I'm understanding the bug comments it sounds like additional testing
has shown that the patch doesn't actually fix the problem. Based on that
I'm nacking these patches.
More information about the kernel-team
mailing list