[vivid][SRU][PATCH 0/2] LP#1476900 Intel 8260 Wifi/Bluetooth Firmware

Seth Forshee seth.forshee at canonical.com
Fri Jul 31 12:49:38 UTC 2015


On Fri, Jul 31, 2015 at 09:51:28AM +0800, Phidias Chiang wrote:
> Perhaps that's because the patch content is binary and causes some
> trouble. When I send the patches to myself patch 1/2 also delayed.
> 
> Since the missing patch is a clear cherry-pick for both Trusty and Vivid,
> if you don't mind I'll send the pull request directly in this mail. If it's
> not
> properly, please let me know and I'll resend it in more proper way, thank
> you.
> 
> ----
> The following changes since commit c6c4150eaaffef76d8e3a3be13c822f0e2cd4dc6:
> 
>   iwlwifi: add new -13 firmware for iwlmvm devices (2015-06-18 20:06:17
> +0300)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
> 
> for you to fetch changes up to c6c4150eaaffef76d8e3a3be13c822f0e2cd4dc6:
> 
>   iwlwifi: add new -13 firmware for iwlmvm devices (2015-06-18 20:06:17
> +0300)

This isn't how pull requests are supposed to work. If I pull this I will
get a lot more than just the two commits you want to cherry pick.

But fine, I'll go cherry pick the patches myself. For future reference,
what you should have done is taken the vivid (and trusty) branch of the
Ubuntu linux-firmware repo, cherry picked the patches you want, pushed
those branches to your own public copy of the Ubuntu linux-firmware
repo, then sent a request to pull from that repo/branch. For
linux-firmware I do think pull requests work better than patches since
the contents are almost always binary blobs.

Seth




More information about the kernel-team mailing list